Thanks @rauno56 , The HostDetector.ts file is currently not committed in this PR.

Do you think it should be hosted in core repo or contrib detectors?

Do you think it should be hosted in core repo or contrib detectors?

If it does, so do ProcessDetector imho. I see that the contrib detectors are vendor specific for now and a similar(ProcessDetector) one was here -> added this here as well.

Do you think it should be hosted in core repo or contrib detectors?

If it does, so do ProcessDetector imho. I see that the contrib detectors are vendor specific for now and a similar(ProcessDetector) one was here -> added this here as well.

Sounds reasonable 👍

Codecov Report

Merging #2921 (981c0f1) into main (dc44b86) will decrease coverage by 0.03%.
The diff coverage is 31.57%.

❗ Current head 981c0f1 differs from pull request most recent head 91921be. Consider uploading reports for the commit 91921be to get more accurate results

@@            Coverage Diff             @@
##             main    #2921      +/-   ##
==========================================
- Coverage   91.85%   91.81%   -0.04%     
==========================================
  Files         176       70     -106     
  Lines        5573     2017    -3556     
  Branches     1209      441     -768     
==========================================
- Hits         5119     1852    -3267     
+ Misses        454      165     -289     

Another question is whether it needs to be a separate detector in the first place.
Sure, it does map to spec better this way, and as long it's included in a package with ProcessDetector there's no (significant) harm done, but as an user I wouldn't want to install 3 different detectors for process, os, and host attributes for no good reason.

Another question is whether it needs to be a separate detector in the first place. Sure, it does map to spec better this way, and as long it's included in a package with ProcessDetector there's no (significant) harm done, but as an user I wouldn't want to install 3 different detectors for process, os, and host attributes for no good reason.

I guess people might not always want all the attributes and separating them into different detectors can help use just the attributes needed.
But I can also see how those 3 detectors collect very similar data and might be more useful as one.
An alternative could be to define a composite detector that invokes those 3 detectors and merges the result into a single resource.

An alternative could be to define a composite detector that invokes those 3 detectors and merges the result into a single resource.

Current SDK uses an utility for that.

I guess people might not always want all the attributes and separating them into different detectors can help use just the attributes needed.

I agree, but that might also happen among attributes detected from a single detector. One might only care about PID from the ProcessDetector but find process.command_line mostly dead weight, ergo we'd likely want to enable users to strip away attributes they don't need anyways. It's currently possible with wrapping the detectors with something like the utility mentioned ☝️

I agree, but that might also happen among attributes detected from a single detector. One might only care about PID from the ProcessDetector but find process.command_line mostly dead weight, ergo we'd likely want to enable users to strip away attributes they don't need anyways. It's currently possible with wrapping the detectors with something like the utility mentioned ☝️

Yeah, good points. Might be worth thinking about how to offer such capabilities in the future.
Anyhow, it's not relevant to this PR.
LGTM. Thanks for working on it 💯

Hmm... changing changelog manually creates a situation with a lot of conflict resolution.

I now finally understand the benefit of changefiles.